Add dbug_flag namelist option and remove unused info_dbug #608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is no longer used in the code
Previously this could only be set via a code change
mvertens
requested changes
Nov 23, 2025
Collaborator
mvertens
left a comment
mvertens
left a comment
There was a problem hiding this comment.
@billsacks - this looks good - but where are the code mods that trigger of of the new config variable? Am I missing something?
Member
Author
Oh, right, sorry that I didn't point this out: I found that there was already code to handle a dbug_flag config variable, even though the dbug_flag variable wasn't actually appearing in the config file: Lines 649 to 656 in 18eb93b (The presence of that code was part of what led me to think that the intent was that this variable should be runtime-settable.) |
mvertens
approved these changes
Nov 24, 2025
Collaborator
|
@billsacks - thanks. Great that the code is already there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
(1) Add dbug_flag namelist option to control this flag in the code, rather than requiring source code changes to change this value
(2) Remove unused info_dbug flag
Specific notes
Contributors other than yourself, if any:
CMEPS Issues Fixed (include github issue #):
Are changes expected to change answers? (specify if bfb, different at roundoff, more substantial) - No
Any User Interface Changes (namelist or namelist defaults changes)?
Testing performed
Please describe the tests along with the target model and machine(s)
If possible, please also added hashes that were used in the testing
Ran
SMS_Ld3_D_P8x1.f10_f10_mg37.X.green_gnuwith dbug_flag set at 0 (default) and 11.